Apply formatting add actions #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobileoverlord
force-pushed
the
mix-format
branch
4 times, most recently
from
5750aac
to
7327cad
Compare
danielspofford
requested changes
Apr 8, 2024
.github/workflows/build_test.yml
Outdated
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 |
.github/workflows/build_test.yml
Outdated
| elixir-version: '1.16.2' | ||
| otp-version: '26.2.3' | ||
| - name: Restore dependencies cache | ||
| uses: actions/cache@v3 |
lib/peridio/rat/network.ex
Outdated
| "192.168.0.0/16", | ||
| "10.0.0.0/8" | ||
| ] |> Enum.map(&CIDR.from_string!/1) | ||
| "172.16.0.0/12", |
There was a problem hiding this comment.
can we comment about how we are choosing these IPs (think we did this somewhere else as well recently? remember commenting on a PR the same thing)
mobileoverlord
force-pushed
the
mix-format
branch
2 times, most recently
from
cd98249
to
3313bf6
Compare
mobileoverlord
force-pushed
the
mix-format
branch
from
3313bf6
to
4f8cbe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.